[core] [easy] [no-op] No gtest code in production code #49359
Closed
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/no-test-in-prod
branch
from
b7148ae to
a994c82
Compare
jjyao
approved these changes
Dec 19, 2024
|
Test failures. |
For my change, compilation is enough |
rynewang
reviewed
Dec 19, 2024
| sched_cls_cap_enabled_(RayConfig::instance().worker_cap_enabled()), | ||
| sched_cls_cap_interval_ms_(sched_cls_cap_interval_ms), | ||
| sched_cls_cap_max_ms_(RayConfig::instance().worker_cap_max_backoff_delay_ms()) {} | ||
|
|
||
| void LocalTaskManager::QueueAndScheduleTask(std::shared_ptr<internal::Work> work) { | ||
| // If the local node is draining, the cluster task manager will | ||
| // guarantee that the local node is not selected for scheduling. | ||
| ASSERT_FALSE( |
There was a problem hiding this comment.
which #import did this macro get in from? Shall we also remove that macro, and maybe in bazel target deps?
There was a problem hiding this comment.
For our build file organization, it's not easy to check by bazel target dependency, since we place all files into one giant target.
Lines 675 to 695 in 2dd6061
|
raylet crash in ci |
|
Close it temporarily, reopen when I got more b/w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, shouldn't have gtest assertion code in production; also some minor updates.