Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping others can be confusing #122

Open
zhouaihui opened this issue May 17, 2023 · 0 comments
Open

Ping others can be confusing #122

zhouaihui opened this issue May 17, 2023 · 0 comments
Assignees

Comments

@zhouaihui
Copy link
Member

zhouaihui commented May 17, 2023

#118 did a good job. But something can be improved.

Using send instead of _grpc_ping can result in cleaner code, but it may not be good enough for users.

When parties cannot initiate the code simultaneously, numerous error logs may appear during initialization, which can be confusing for users.

Additionally, the _grpc_ping function disregards exceptions and sets error messages to debug, which may lead users to assume that failed pings are normal. Can this be improved in send?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants