-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ping others can be confusing #122
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#118 did a good job. But something can be improved.
Using
send
instead of_grpc_ping
can result in cleaner code, but it may not be good enough for users.When parties cannot initiate the code simultaneously, numerous error logs may appear during initialization, which can be confusing for users.
Additionally, the
_grpc_ping
function disregards exceptions and sets error messages to debug, which may lead users to assume that failed pings are normal. Can this be improved insend
?The text was updated successfully, but these errors were encountered: