Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add __init__.py. #171

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: add __init__.py. #171

merged 1 commit into from
Aug 10, 2023

Conversation

zhouaihui
Copy link
Member

  • No init.py in protobuf python dirs.

@fengsp fengsp self-requested a review August 8, 2023 03:17
fengsp
fengsp approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@fengsp fengsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouaihui
Copy link
Member Author

A UT is flaky #122

@zhouaihui zhouaihui merged commit e548b01 into ray-project:main Aug 10, 2023
10 of 12 checks passed
@zhouaihui zhouaihui deleted the fix/grpc_init branch August 10, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang approved these changes

@fengsp fengsp fengsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhouaihui @fengsp @jovany-wang