Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grpc proxy plugable. #159

Open
2 tasks
jovany-wang opened this issue Jul 19, 2023 · 1 comment
Open
2 tasks

Make grpc proxy plugable. #159

jovany-wang opened this issue Jul 19, 2023 · 1 comment
Labels
Milestone

Comments

@jovany-wang
Copy link
Collaborator

  • Move grpc_config out of config file.
  • Make new communication component easy to plugin.
@jovany-wang jovany-wang added the p0 label Jul 19, 2023
@jovany-wang jovany-wang added this to the release0.1.1 milestone Jul 19, 2023
@jovany-wang jovany-wang mentioned this issue Jul 20, 2023
3 tasks
@fengsp
Copy link
Collaborator

fengsp commented Jul 21, 2023

Here is a really simple idea, we could just pass raw config dict to ProxyClass:

  • since this is a raw dict, user could add any custom confs,user could use the raw dict or convert it to a config instance
  • for the builtin gRPCProxy,we would build a config instance inside init method

However, config error won't be detected until actor remote call, so we need a way to let user find out config errors early

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants