-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg config. #164
Reorg config. #164
Conversation
jovany-wang
commented
Jul 19, 2023
•
edited
Loading
edited
- deprecated specifying config per party and also remove the related unit test.
- made all face config API as dict type instead of an internal strong type.
- simplified param address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep addresses
as simple as possible, i.e. addresses = {'alice': str, 'bob': str}
, instead of a nested dict.
@NKcqx Then how can we make |
Since |
I don't have idea yet. Let's move forward as what you described here. |
@NKcqx @fengsp @zhouaihui Please help another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM