Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg config. #164

Merged
merged 24 commits into from
Jul 21, 2023
Merged

Reorg config. #164

merged 24 commits into from
Jul 21, 2023

Conversation

jovany-wang
Copy link
Collaborator

@jovany-wang jovany-wang commented Jul 19, 2023

  • deprecated specifying config per party and also remove the related unit test.
  • made all face config API as dict type instead of an internal strong type.
  • simplified param address.

Signed-off-by: Qing Wang <kingchin1218@gmail.com>
Signed-off-by: Qing Wang <kingchin1218@gmail.com>
Signed-off-by: Qing Wang <kingchin1218@gmail.com>
@jovany-wang jovany-wang changed the title WIP: Finalize config Type config as a dict. Jul 19, 2023
@jovany-wang jovany-wang changed the title Type config as a dict. Make config as a dict type. Jul 19, 2023
@jovany-wang jovany-wang added the p0 label Jul 19, 2023
@jovany-wang jovany-wang added this to the release0.1.1 milestone Jul 19, 2023
@jovany-wang jovany-wang changed the title Make config as a dict type. Reorg config. Jul 19, 2023
Copy link
Collaborator

@NKcqx NKcqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep addresses as simple as possible, i.e. addresses = {'alice': str, 'bob': str}, instead of a nested dict.

@jovany-wang
Copy link
Collaborator Author

jovany-wang commented Jul 20, 2023

@NKcqx Then how can we make listening addresses work?

fed/proxy/grpc/grpc_proxy.py Outdated Show resolved Hide resolved
tests/test_listen_addr.py Show resolved Hide resolved
fed/api.py Show resolved Hide resolved
@NKcqx
Copy link
Collaborator

NKcqx commented Jul 20, 2023

@NKcqx Then how can we make listening addresses work?

Since listen_addr is used inside ReceiveProxy, i.e. cross-silo communication, and it's kinda like an advanced config, what do you think we move it to CrossSiloMessageConfig?

@jovany-wang
Copy link
Collaborator Author

Since listen_addr is used inside ReceiveProxy, i.e. cross-silo communication, and it's kinda like an advanced config, what do you think we move it to CrossSiloMessageConfig?

I don't have idea yet. Let's move forward as what you described here.

@jovany-wang
Copy link
Collaborator Author

jovany-wang commented Jul 20, 2023

@fengsp @NKcqx
Let us move listening addresses into cross silo config as a workaround right now.

@fengsp
Copy link
Collaborator

fengsp commented Jul 20, 2023

@fengsp @NKcqx Let us move listening addresses into cross silo config as a workaround right now.

I believe this is right, since we do not need to config listen_addr for other parties at all

Signed-off-by: Qing Wang <kingchin1218@gmail.com>
Signed-off-by: Qing Wang <kingchin1218@gmail.com>
@jovany-wang
Copy link
Collaborator Author

@NKcqx @fengsp @zhouaihui Please help another review.

Signed-off-by: Qing Wang <kingchin1218@gmail.com>
Copy link
Collaborator

@fengsp fengsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovany-wang jovany-wang merged commit 270546d into main Jul 21, 2023
@jovany-wang jovany-wang deleted the public_config_api branch July 21, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants