Replaceing KV actor by Ray API #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovany-wang
reviewed
Jun 27, 2023
fed/_private/compatible_utils.py
Outdated
| return ray.get(o) | ||
| # Note(NKcqx): internval_kv is always initiated after `ray.init`, | ||
| # calling this is equal to directly return "True" | ||
| return self._client_api_stub._internal_kv_initialized() |
There was a problem hiding this comment.
So we should mark this method as deprecated?
|
|
||
| def reset(self): | ||
| o = self._internal_kv_actor.reset.remote() | ||
| return ray.get(o) | ||
| # Note(NKcqx): No `gcs_client` is instantiated for kv, and the 'initialized' |
Signed-off-by: NKcqx <892670992@qq.com>
|
Unfortunately, Ray's client mode internal_kv accessing has a BUG that causes the call of |
|
It turns out to be a dumb BUG in Ray, fix PR: |
|
If the current ray doesn't support it, how can we handle to get compatible with all versions? |
|
Do we need go with this PR? @ray-project/rayfed |
Signed-off-by: NKcqx <892670992@qq.com> Conflicts: fed/_private/compatible_utils.py tests/test_internal_kv.py
Signed-off-by: NKcqx <892670992@qq.com>
Signed-off-by: NKcqx <892670992@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #135