Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Job-Mismatch request #174

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Handle Job-Mismatch request #174

merged 5 commits into from
Aug 21, 2023

Conversation

NKcqx
Copy link
Collaborator

@NKcqx NKcqx commented Aug 21, 2023

The job mismatch request should be identified as a sending failure because the request's content is not yet processed, though the request was physically sent.

This PR distinguished the error code in [400, 500), which indicates a "request error", and throws an exception as other types of sending failure did.

Signed-off-by: paer <chenqixiang.cqx@antgroup.com>
@NKcqx NKcqx requested review from fengsp and a team August 21, 2023 03:46
paer and others added 4 commits August 21, 2023 11:49
Signed-off-by: paer <chenqixiang.cqx@antgroup.com>
Signed-off-by: NKcqx <892670992@qq.com>
Signed-off-by: paer <chenqixiang.cqx@antgroup.com>
Copy link
Collaborator

@fengsp fengsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NKcqx NKcqx merged commit c6c3f11 into main Aug 21, 2023
13 checks passed
@jovany-wang jovany-wang deleted the job_mismatch_err branch August 21, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants