Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Anonymous_job as default job name. #185

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: use Anonymous_job as default job name. #185

merged 1 commit into from
Dec 12, 2023

Conversation

zhouaihui
Copy link
Member

@zhouaihui zhouaihui commented Dec 11, 2023 •
edited
Loading

Anonymous is confusing somehow as the default job name. Give it an explicit name.

Before

2023-12-11 12:29:32 INFO barriers.py:295 [bob] -- [Anonymous] SenderProxyActor has successfully created.

After

2023-12-11 12:29:32.598 INFO barriers.py:295 [bob] -- [Anonymous_job] SenderProxyActor has successfully created.

NKcqx
NKcqx approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@NKcqx NKcqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouaihui zhouaihui merged commit 6035939 into ray-project:main Dec 12, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NKcqx NKcqx NKcqx approved these changes

@jovany-wang jovany-wang Awaiting requested review from jovany-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouaihui @NKcqx