Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use None as default value for job_name param in init. #191

Merged
merged 1 commit into from
Jan 2, 2024
Merged

refactor: use None as default value for job_name param in init. #191

merged 1 commit into from
Jan 2, 2024

Conversation

zhouaihui
Copy link
Member

Use None as default value for job_name in fed.init just same as other params.

NKcqx
NKcqx approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@NKcqx NKcqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jovany-wang
jovany-wang approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it doesn't change any functionality.

@zhouaihui zhouaihui merged commit 1f76e2e into ray-project:main Jan 2, 2024
8 of 13 checks passed
@zhouaihui zhouaihui deleted the refactor/job_name_param_default branch January 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NKcqx NKcqx NKcqx approved these changes

@jovany-wang jovany-wang jovany-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhouaihui @jovany-wang @NKcqx