feat: unittest on more ray versions. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also close #195 |
zhouaihui
force-pushed
the
feat/ut_on_more_ray_versions
branch
from
0cd65b0
to
94c8898
Compare
|
Further work: #199 |
jovany-wang
approved these changes
Jan 17, 2024
| @@ -11,7 +11,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| ray_version: [2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0] | |||
| ray_version: [2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.1, 2.6.3, 2.7.1, 2.8.1] | |||
There was a problem hiding this comment.
Let's deprecate 2.0.0, 2.1.0, 2.2.0 and 2.3.0? @fengsp CC
| @@ -3,3 +3,4 @@ ray>=1.13.0 | |||
| cloudpickle | |||
| pickle5==0.0.11; python_version < '3.8' | |||
| protobuf | |||
| grpcio | |||
There was a problem hiding this comment.
I guess we should pin a fixed version, at least pin a range of version set.
There was a problem hiding this comment.
Any idea？Use ray 2.4 grpcio<=1.51.3,>=1.32.0?
There was a problem hiding this comment.
@zhouaihui I'm merging this PR. Please feel free to create a new PR to pin the grpc version.
jovany-wang
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: client mode does not work on ray>2.4