Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unittest on more ray versions. #194

Merged
merged 24 commits into from
Jan 18, 2024

Conversation

zhouaihui
Copy link
Member

@zhouaihui zhouaihui commented Jan 3, 2024

TODO: client mode does not work on ray>2.4

@jovany-wang
Copy link
Collaborator

This should also close #195

@zhouaihui
Copy link
Member Author

Further work: #199

@zhouaihui zhouaihui requested a review from fengsp January 17, 2024 08:18
@@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
ray_version: [2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0]
ray_version: [2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.1, 2.6.3, 2.7.1, 2.8.1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable 2.9?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deprecate 2.0.0, 2.1.0, 2.2.0 and 2.3.0? @fengsp CC

@@ -3,3 +3,4 @@ ray>=1.13.0
cloudpickle
pickle5==0.0.11; python_version < '3.8'
protobuf
grpcio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should pin a fixed version, at least pin a range of version set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea?Use ray 2.4 grpcio<=1.51.3,>=1.32.0?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouaihui I'm merging this PR. Please feel free to create a new PR to pin the grpc version.

@jovany-wang jovany-wang merged commit bbc4bc2 into ray-project:main Jan 18, 2024
14 checks passed
@zhouaihui zhouaihui deleted the feat/ut_on_more_ray_versions branch January 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants