Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build][Zig] Reviewed compatibility with latest zig master branch (v0.14.0) #4620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Joonsey
Copy link

@Joonsey Joonsey commented Dec 19, 2024

defineCMacro is removed, this is my solution to get raylib to build with zig 0.14.0+2540

@Joonsey Joonsey changed the title using addCMacro instead of defineCMacro build compatible with zig master Dec 19, 2024
@HaxSam
Copy link
Contributor

HaxSam commented Dec 19, 2024

Shouldn't we wait until zig 0.14.0 is released?

@Joonsey
Copy link
Author

Joonsey commented Dec 20, 2024

Sure, can leave the mr open in any case until then maybe

@raysan5
Copy link
Owner

raysan5 commented Dec 23, 2024

@Joonsey @HaxSam when is Zig 0.14.0 being released?

@raysan5 raysan5 changed the title build compatible with zig master [build] Reviewed compatibility with latest zig master branch (v0.14.0) Dec 23, 2024
@Joonsey
Copy link
Author

Joonsey commented Dec 23, 2024

I'm unfamiliar, however they do very much recommend using master.

With a release cadance every ~6 months.

I can update this PR until release if that's preferred?

@raysan5 raysan5 changed the title [build] Reviewed compatibility with latest zig master branch (v0.14.0) [build][Zig] Reviewed compatibility with latest zig master branch (v0.14.0) Dec 23, 2024
@HaxSam
Copy link
Contributor

HaxSam commented Dec 23, 2024

Also, the zig binding from @Not-Nik (raylib-zig) only uses the latest release from zig. See CONTRIBUTING.md
To keep compatibility with the raylib build.zig it would be preferential to do the same here.

@Not-Nik
Copy link
Contributor

Not-Nik commented Dec 23, 2024

I do that so I don't have to keep updating the binding for each breaking master change, but since we JUST had a raylib release and a new Zig release is imminent it's fine to update the build.zig from my side. Zig being a very immature language forces me to switch to the -dev versions of raylib anyways, so in this I'd rather have an updated build file sooner than later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants