Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guardian starts rest and grpc on same port #388

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

kushsharma
Copy link
Member

  • start up fix to use different port for grpc
  • docs fix for gcs
  • remove unsupported shield identity client

- start up fix to use different port for grpc
- docs fix for gcs
- remove unsupported shield identity client

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@coveralls
Copy link

coveralls commented Aug 29, 2023

Pull Request Test Coverage Report for Build 6013719453

  • 4 of 6 (66.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 75.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/bigquery/client.go 0 2 0.0%
Totals Coverage Status
Change from base Build 5419609598: 0.003%
Covered Lines: 8137
Relevant Lines: 10711

💛 - Coveralls

@kushsharma kushsharma merged commit 9954153 into main Aug 30, 2023
5 checks passed
@kushsharma kushsharma deleted the basic-startup-fixes branch August 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants