fix: bug in appeal creation #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bsushmith
commented
Sep 21, 2023
bsushmith
commented
- bug: If a final approval step of the policy gets skipped or allow_failed is true, then the appeal gets auto_approved, but the grant will not get created and no access is provided.
- fix bug by adding a check for last step
- add test-short cmd to makefile to be able to run quick service layer tests by skipping docker led store test cases.
- bug: If a final approval step of the policy gets skipped or allow_failed is true, then the appeal gets auto_approved, but the grant will not get created and no access is provided. - fix bug by adding a check for last step - add test-short cmd to makefile to be able to run quick service layer tests by skipping docker led store test cases.
bsushmith
requested review from
ravisuhag,
rahmatrhd,
AkarshSatija and
mabdh
as code owners
AkarshSatija
approved these changes
Oct 8, 2023
|
@bsushmith test are failing for this. |
|
@bsushmith fixed. It was a typo in makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.