Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(approval): support search query and filter by resource type and … #391

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

ravisuhag
Copy link
Member

…account_type

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6439919155

  • 562 of 928 (60.56%) changed or added relevant lines in 26 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 74.325%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1beta1/activity.go 0 1 0.0%
utils/time.go 0 1 0.0%
api/handler/v1beta1/appeal.go 40 42 95.24%
domain/activity.go 0 2 0.0%
plugins/providers/bigquery/config.go 3 5 60.0%
internal/store/postgres/approval_repository.go 55 58 94.83%
utils/struct.go 8 12 66.67%
api/handler/v1beta1/grant.go 26 33 78.79%
plugins/providers/bigquery/model.go 8 18 44.44%
core/provider/service.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/grant.go 1 54.55%
internal/store/postgres/approval_repository.go 1 89.15%
plugins/providers/bigquery/activity.go 5 50.0%
Totals Coverage Status
Change from base Build 6064664402: -0.8%
Covered Lines: 8621
Relevant Lines: 11599

💛 - Coveralls

@kushsharma kushsharma merged commit 683a285 into main Oct 7, 2023
5 checks passed
@kushsharma kushsharma deleted the feat/filter branch October 7, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants