Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiple slack notifier #393

Merged
merged 10 commits into from
Oct 20, 2023
Merged

feat: multiple slack notifier #393

merged 10 commits into from
Oct 20, 2023

Conversation

Chief-Rishab
Copy link
Member

No description provided.

@Chief-Rishab Chief-Rishab changed the title Feat multislack notifier Feat multiple slack notifier Oct 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6541959777

  • 93 of 153 (60.78%) changed or added relevant lines in 10 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 73.959%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/dataplex/client.go 0 4 0.0%
domain/provider.go 0 6 0.0%
plugins/notifiers/client.go 35 43 81.4%
plugins/providers/bigquery/provider.go 14 22 63.64%
internal/store/postgres/store.go 6 16 37.5%
plugins/notifiers/slack/client.go 34 58 58.62%
Files with Coverage Reduction New Missed Lines %
plugins/providers/dataplex/client.go 1 3.7%
plugins/notifiers/slack/client.go 19 54.09%
Totals Coverage Status
Change from base Build 6456632890: -0.4%
Covered Lines: 8671
Relevant Lines: 11724
💛 - Coveralls

@kushsharma kushsharma changed the title Feat multiple slack notifier feat: multiple slack notifier Oct 18, 2023
@ravisuhag ravisuhag merged commit bcbbde8 into main Oct 20, 2023
5 checks passed
@ravisuhag ravisuhag deleted the feat-multislack-notifier branch October 20, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushsharma kushsharma kushsharma approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chief-Rishab @coveralls @kushsharma @ravisuhag