Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get default provider roles api #399

Merged
merged 4 commits into from
Dec 6, 2023
Merged

feat: add get default provider roles api #399

merged 4 commits into from
Dec 6, 2023

Conversation

Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Dec 3, 2023 •
edited
Loading

@coveralls
Copy link

coveralls commented Dec 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7109527714

  • 0 of 132 (0.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 72.993%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/dataplex/provider.go 0 3 0.0%
plugins/providers/gcloudiam/provider.go 0 3 0.0%
plugins/providers/noop/provider.go 0 3 0.0%
plugins/providers/tableau/provider.go 0 3 0.0%
core/provider/service.go 0 6 0.0%
api/handler/v1beta1/provider.go 0 8 0.0%
plugins/providers/grafana/provider.go 0 9 0.0%
plugins/providers/gcs/provider.go 0 17 0.0%
plugins/providers/bigquery/provider.go 0 22 0.0%
plugins/providers/metabase/provider.go 0 26 0.0%
Totals Coverage Status
Change from base Build 7069016607: -0.8%
Covered Lines: 8673
Relevant Lines: 11882
💛 - Coveralls

kushsharma
kushsharma approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kushsharma kushsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small variable name fix, rest LGTM

api/handler/v1beta1/grpc.go Outdated Show resolved Hide resolved
@kushsharma kushsharma merged commit faf5807 into main Dec 6, 2023
5 checks passed
@kushsharma kushsharma deleted the feat-get-provider-roles-api branch December 6, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushsharma kushsharma kushsharma approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chief-Rishab @coveralls @kushsharma