-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimised fetching key from keystore dir #1196
Closed
Yashk767
wants to merge
10
commits into
develop
from
yash/raz-794-fetching-private-key-every-time-increases-goroutine-count
Closed
refactor: optimised fetching key from keystore dir #1196
Yashk767
wants to merge
10
commits into
develop
from
yash/raz-794-fetching-private-key-every-time-increases-goroutine-count
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests failing @Yashk767 |
ashish10677
requested changes
Mar 20, 2024
ashish10677
reviewed
Mar 20, 2024
ashish10677
previously approved these changes
Mar 21, 2024
…nto yash/raz-794-fetching-private-key-every-time-increases-goroutine-count
Please follow this pattern. cc: @ashish10677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when fetching keys from the keystore, we used ks.Accounts(), which created a new goroutine every time. This approach led to goroutines waiting indefinitely, which was inefficient and could potentially cause resource exhaustion issues. To optimize this process and avoid unnecessary resource consumption, the solution is to use the same keystore instance every time to call ks.Accounts() will solves the issue of increasing go routines.
So this PR optimises keystore file fetching to prevent indefinite waiting by goroutines.
Fixes #1195
Solution
Creating and initialising the keystore instance once at the start and using the same to call
ks.Accounts()
at every fetching of pKey call doesnt increase the goroutine count and it also gives the updated keystore cache at the time of fetching accounts.How Has This Been Tested?