fix: added context parameter to functions to sync with updated generic retry function to make build successful #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashk767
changed the title
ashish10677
approved these changes
Oct 10, 2024
rajkharvar
approved these changes
Oct 10, 2024
Yashk767
deleted the
yash/raz-1060-build-is-failing-after-merging-replacing-custom-retry-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging #1235 to develop, the function signature for
InvokeFunctionWithRetryAttemptswas updated with addition of context as a parameter.So the the changes in PR #1252 wasn't rebased to the updated changes and was merged to develop without rebasing.
So it cause the build to go fail, this PR adds context as a parameter to the functions needed and will make the compilation and build successful.
And fixes respective tests.
Fixes https://linear.app/interstellar-research/issue/RAZ-1060
This is the extended fix for issue https://linear.app/interstellar-research/issue/RAZ-1044
How Has This Been Tested?
Ran a node on local for few epochs and tested the changes reflected.