feat: Add Table component
#1797
Conversation
🦋 Changeset detectedLatest commit: 7ff6a20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ff6a20:
|
|
✅ PR title follows Conventional Commits specification. |
| @@ -135,6 +136,7 @@ | |||
| "@babel/preset-react": "7.16.5", | |||
| "@babel/preset-typescript": "7.16.5", | |||
| "@codesandbox/sandpack-react": "1.16.0", | |||
| "@emotion/react": "11.11.1", | |||
There was a problem hiding this comment.
Oh wait, does that mean now consumers will have bundle of both styled comp and emotion?
There was a problem hiding this comment.
Yup thats a down side of this library. Mentioned it in the API decision 😢
Doesnt add much though
There was a problem hiding this comment.
I see, so does the library marks @emotion/react as peerDep?
It should, otherwise all the components will have to carry emotion bundle this is what I was exploring also.
Also, let's move @table-library/react-table-library to peerDep, we don't need to include this on our bundle if a consumer doesn't use Table keeping in mind treeshaking/codesplitting things.
There was a problem hiding this comment.
Checking
packages/blade/package.json
Outdated
| "@table-library/react-table-library": "4.1.7", | ||
| "@emotion/react": "11.11.1", |
There was a problem hiding this comment.
Another thing we should do that we didn't on other peerDeps, is instead of pinning them we should use ranges, otherwise consumers will have to use the exact version down the the patch otherwise there will be mismatches.
@emotion/react: ^11.11.1
There was a problem hiding this comment.
Yup, done!
Adds Table Component
Documentation: #1834