-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tooltip e2e #1988
test: add tooltip e2e #1988
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
✅ PR title follows Conventional Commits specification. |
Done |
width="80px" | ||
height="80px" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why pass manually? this would cause issue when consumer use it the way you were using before right? also why use basebox? we can use Box
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an example showing how to pass proper props like onMouseOver
onMouseHover
ref
tabIndex
to properly create a trigger for tooltip. The styling & usage of box etc hardly matters in this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus Box doesn't even support onBlur onFocus etc props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but what i'm trying to ask is if consumer will create custom tooltip they'll have to pass these things as well right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. events are required for users to create custom triggers. This is already well documented in the main story example
https://blade.razorpay.com/?path=/story/components-tooltip--with-custom-trigger
No description provided.