Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tooltip e2e #1988

Merged
merged 3 commits into from
Jan 25, 2024
Merged

test: add tooltip e2e #1988

merged 3 commits into from
Jan 25, 2024

Conversation

anuraghazra
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: b01dc59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

✅ PR title follows Conventional Commits specification.

@kamleshchandnani
Copy link
Collaborator

overall lgtm except the custom interactive trigger which shows tooltip in the center
image

@anuraghazra
Copy link
Member Author

Done

Comment on lines +99 to +100
width="80px"
height="80px"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pass manually? this would cause issue when consumer use it the way you were using before right? also why use basebox? we can use Box right?

Copy link
Member Author

@anuraghazra anuraghazra Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example showing how to pass proper props like onMouseOver onMouseHover ref tabIndex to properly create a trigger for tooltip. The styling & usage of box etc hardly matters in this example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus Box doesn't even support onBlur onFocus etc props.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but what i'm trying to ask is if consumer will create custom tooltip they'll have to pass these things as well right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. events are required for users to create custom triggers. This is already well documented in the main story example

https://blade.razorpay.com/?path=/story/components-tooltip--with-custom-trigger

@kamleshchandnani kamleshchandnani merged commit 27fe572 into master Jan 25, 2024
14 checks passed
@kamleshchandnani kamleshchandnani deleted the anu/e2e-tooltip branch January 25, 2024 06:17
anuraghazra added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants