Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(SideNav): API Decision #2149

Merged
merged 26 commits into from
May 28, 2024
Merged

docs(SideNav): API Decision #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
916866f
docs: init API
saurabhdaware May 2, 2024
99d2cfd
fix: image width
saurabhdaware May 3, 2024
2eec0bb
feat: add images, props, examples
saurabhdaware May 3, 2024
7f3e31f
feat: add referrences and open questions
saurabhdaware May 3, 2024
84588d1
feat: update references
saurabhdaware May 3, 2024
24ee1af
feat: add onClick
saurabhdaware May 3, 2024
5b0ee97
fix: image heights
saurabhdaware May 3, 2024
9aad19b
fix: overview image layout shift
saurabhdaware May 3, 2024
d723b49
fix: define width
saurabhdaware May 3, 2024
2e1d2ae
fix: rename images
saurabhdaware May 3, 2024
253cef3
feat: add poc links in api decision
saurabhdaware May 3, 2024
840be95
feat: add another question
saurabhdaware May 3, 2024
52405b5
fix: menu heading prop
saurabhdaware May 6, 2024
c2a1f4c
fix: SideNavItem naming
saurabhdaware May 6, 2024
7d14e99
feat: add tooltip on trailing example
saurabhdaware May 8, 2024
ceb5d2e
feat: add togglecollapseditem handler for analytics
saurabhdaware May 8, 2024
77092a7
feat: rename prop
saurabhdaware May 8, 2024
75dd604
feat: add description for open questions
saurabhdaware May 8, 2024
f140cc6
feat: add design open question
saurabhdaware May 8, 2024
ac233a1
fix: typo
saurabhdaware May 8, 2024
d83f40f
feat: use as prop on SideNavLink
saurabhdaware May 8, 2024
04ddc51
fix: remove SideNavLevel title prop
saurabhdaware May 8, 2024
40873ea
feat: add open question
saurabhdaware May 10, 2024
cc3d7bf
fix: update api decision
saurabhdaware May 27, 2024
008991f
feat: add sidenav banner and api changes
saurabhdaware May 27, 2024
5e6d4db
docs: add hover only note in trailing
saurabhdaware May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
623 changes: 623 additions & 0 deletions packages/blade/src/components/SideNav/_decisions/decisions.md
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added packages/blade/src/components/SideNav/_decisions/nav-banner.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/nav-header.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navfooter-eg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlevels-eg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-4.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-active.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navlink-eg-tooltip.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added packages/blade/src/components/SideNav/_decisions/navsection-eg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading