Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Avatar component API #2154

Merged
merged 13 commits into from
May 17, 2024
Merged

docs: Avatar component API #2154

merged 13 commits into from
May 17, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 5, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78612c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 5, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78612c4:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented May 5, 2024 •
edited
Loading

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬇ Switch 4.524 4.522 -0.002 KB

Generated by 🚫 dangerJS against 78612c4

@snitin315 snitin315 marked this pull request as ready for review May 9, 2024 07:13
Rozamo
Rozamo reviewed May 9, 2024
View reviewed changes
packages/blade/src/components/Avatar/_decisions/decisions.md
- `Rama Krushna Behra` - `RK`
- `Nitin` - `NI`
- `Anurag Hazra` - `AH`
- If there's no `name` prop, we use a default avatar.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the default avatar configurable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the color is configurable, the icon remains the same.

Screenshot 2024-05-09 at 2 31 55 PM

@snitin315 snitin315 mentioned this pull request May 14, 2024
Merged
5 tasks
@anuraghazra anuraghazra merged commit 85631e1 into master May 17, 2024
14 checks passed
@anuraghazra anuraghazra deleted the docs/avatar-api branch May 17, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozamo Rozamo Rozamo left review comments

@anuraghazra anuraghazra anuraghazra approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar chaitanyadeorukhkar is a code owner

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@saurabhdaware saurabhdaware Awaiting requested review from saurabhdaware saurabhdaware is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snitin315 @rzpcibot @anuraghazra @Rozamo