Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revamped top-nav component #2392

Merged
merged 15 commits into from
Oct 29, 2024
Merged

feat: revamped top-nav component #2392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
441da58
feat: added new topnav overflow interaction
anuraghazra Oct 24, 2024
398a6a2
chore: change children to title
anuraghazra Oct 25, 2024
251637f
chore: update
anuraghazra Oct 25, 2024
3d64e58
chore: remove divider hider color
anuraghazra Oct 27, 2024
b21ebce
chore: remove context
anuraghazra Oct 27, 2024
9f79629
chore: support as button in tabnabitem
anuraghazra Oct 27, 2024
6207003
chore: update
anuraghazra Oct 28, 2024
419763d
chore: update zindex
anuraghazra Oct 28, 2024
4d11b11
chore: revert sidenab width
anuraghazra Oct 29, 2024
4e20f48
docs: add new topnav documentation (#2393)
anuraghazra Oct 29, 2024
ccf3883
chore: change type name
anuraghazra Oct 29, 2024
173638b
chore: fix mobile
anuraghazra Oct 29, 2024
4e4a862
Create wicked-oranges-whisper.md
anuraghazra Oct 29, 2024
78a17c0
chore: update
anuraghazra Oct 29, 2024
7f9fb91
chore: update
anuraghazra Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/wicked-oranges-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@razorpay/blade": minor
---

feat(blade): revamped top-nav component

> NOTE:
> This might be a breaking change for you, if your project uses the older deprecated TopNav.

6 changes: 3 additions & 3 deletions packages/blade/src/components/Menu/VisualSubComponents/MenuHeaderFooter.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const _MenuHeader = ({
testID,
}: MenuHeaderProps): React.ReactElement => {
return (
<>
<Box marginBottom="spacing.3">
<BaseHeader
title={title}
subtitle={subtitle}
Expand All @@ -37,7 +37,7 @@ const _MenuHeader = ({
showDivider={false}
/>
<MenuDivider />
</>
</Box>
);
};

Expand All @@ -47,7 +47,7 @@ const MenuHeader = assignWithoutSideEffects(_MenuHeader, {

const _MenuFooter = ({ children, testID }: MenuFooterProps): React.ReactElement => {
return (
<Box marginTop="spacing.2">
<Box marginTop="spacing.3">
<MenuDivider />
<BaseFooter
metaComponentName={MetaConstants.MenuFooter}
Expand Down
Loading
Loading