test: add new topnav tests #2394
Conversation
anuraghazra
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
snitin315 and
saurabhdaware
as code owners
|
|
✅ PR title follows Conventional Commits specification. |
anuraghazra
changed the base branch from
anu/new-topnav
to
anu/new-topnav-docs
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb582e8:
|
Bundle Size ReportUpdated Components
|
| canvasElement.style.width = '300px'; | ||
| await sleep(500); | ||
| await expect(queryByRole('menuitem', { name: 'Payroll' })).toBeVisible(); | ||
| await expect(queryByRole('menuitem', { name: 'Payments' })).toBeVisible(); |
There was a problem hiding this comment.
add a test that will check that the items that were out of the viewport are not visible since they'll be moved under overflowing menu?
| await expect(queryByRole('menuitem', { name: 'Payroll' })).toBeVisible(); | ||
| await expect(queryByRole('menuitem', { name: 'Payments' })).toBeVisible(); | ||
|
|
||
| canvasElement.style.width = '100%'; |
There was a problem hiding this comment.
what does width 100% check here?
There was a problem hiding this comment.
It doesn't check anything i'm resetting the canvas to be full width.
* feat: added tabnav and topnav docs * chore: fix build * chore: kamlesh feedback * chore: update menu header/footer margin * chore: remove chevron change * chore: update icon * chore: update menu padding * test: add new topnav tests (#2394) * chore: add new topnav tests * chore: update more to button * chore: update snaps * chore: snaps * chore: revert sidenab width * chore: update snaps * chore: test for null * chore: update
* feat: added new topnav overflow interaction * chore: change children to title * chore: update * chore: remove divider hider color * chore: remove context * chore: support as button in tabnabitem * chore: update * chore: update zindex * chore: revert sidenab width * docs: add new topnav documentation (#2393) * feat: added tabnav and topnav docs * chore: fix build * chore: kamlesh feedback * chore: update menu header/footer margin * chore: remove chevron change * chore: update icon * chore: update menu padding * test: add new topnav tests (#2394) * chore: add new topnav tests * chore: update more to button * chore: update snaps * chore: snaps * chore: revert sidenab width * chore: update snaps * chore: test for null * chore: update * chore: change type name * chore: fix mobile * Create wicked-oranges-whisper.md * chore: update * chore: update
Description
Changes
Additional Information
Component Checklist