Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blade): Date Picker does not fire onInput event [DSSUP-127] #2401

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tewarig
Copy link

@tewarig tewarig commented Nov 4, 2024

Description

Date picker component does not fire change or input event when the value is changed or committed. Expectation is to behave like an input field with type as date.

Changes

This pr -

  • adds onInput prop in Datepicker
  • add mode presets in Datepicker with Presets example

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 58ad183

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ PR title follows Conventional Commits specification.

@tewarig tewarig changed the title fix(DSSUP-127): does not fire fire event onInput fix(DSSUP-127): Date Picker does not fire fire event onInput Nov 4, 2024
@tewarig tewarig changed the title fix(DSSUP-127): Date Picker does not fire fire event onInput fix(DSSUP-127): Date Picker does not fire event onInput Nov 4, 2024
Copy link

codesandbox-ci bot commented Nov 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58ad183:

Sandbox Source
razorpay/blade: basic Configuration

@tewarig tewarig changed the title fix(DSSUP-127): Date Picker does not fire event onInput fix(DSSUP-127): Date Picker does not fire onInput event Nov 4, 2024
@rzpcibot
Copy link
Collaborator

rzpcibot commented Nov 4, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
DatePicker 85.465 85.479 +0.014 KB

Generated by 🚫 dangerJS against 58ad183

@tewarig tewarig changed the title fix(DSSUP-127): Date Picker does not fire onInput event fix(blade): Date Picker does not fire onInput event Nov 4, 2024
@tewarig tewarig changed the title fix(blade): Date Picker does not fire onInput event fix(blade): Date Picker does not fire onInput event [DSSUP-127] Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants