fix(blade): File upload does not fire change input event when file is dropped [DSSUP-128] #2402
Conversation
tewarig
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
🦋 Changeset detectedLatest commit: c257e6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
tewarig
changed the title
tewarig
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c257e6d:
|
tewarig
changed the title
| /** | ||
| * Callback function triggered when files are selected or when a file is dropped into the upload area | ||
| */ | ||
| onInput?: ({ name, fileList }: { name?: string; fileList: BladeFileList }) => void; |
There was a problem hiding this comment.
This seems same as onChange , are we planning to deprecate the onChange prop in favor of onInput? If so, we need to update the description accordingly.
There was a problem hiding this comment.
In the case of FileUpload, both onChange and onInput should exhibit the same behavior.
CodePen example demonstrates this.
Currently, however, the FileUpload component lacks an onInput prop, so it does not trigger the onInput event when a file is dropped. we need to ensure that native input events are triggered in FileUpload for Analytics SDK .
https://razorpay.atlassian.net/browse/DSSUP-128
tewarig
changed the title
Description
FileUpload component does not fire
changeorinputevent when the file is dropped.Changes
Additional Information
Component Checklist