Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rbonghi committed Oct 27, 2022
1 parent 98366a7 commit 0fde084
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
1 change: 0 additions & 1 deletion Dockerfile.humble.base
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ RUN mkdir -p ${ROS_ROOT}/src \
&& rm ${ROS_ROOT}/*.rosinstall \
# Install dependencies using rosdep
&& apt-get update \
&& rosdep init \
&& rosdep update \
&& rosdep install -y \
--ignore-src \
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile.isaac
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# DEALINGS IN THE SOFTWARE.


ARG BASE_IMAGE=rbonghi/isaac-ros-base:humble-core-devel
ARG BASE_IMAGE=rbonghi/isaac-ros-base:humble-base-devel
FROM ${BASE_IMAGE}
LABEL io.k8s.display-name="isaac_ros humble"
LABEL name="isaac_ros humble"
Expand Down Expand Up @@ -66,12 +66,11 @@ RUN mkdir -p ${ROS_ROOT}/src \
slam_toolbox \
ompl \
navigation2 \
nav2 \
> ros2.${ROS_DISTRO}.${ROS_PKG}.rosinstall \
&& cat ros2.${ROS_DISTRO}.${ROS_PKG}.rosinstall \
# Load variable ROS2
&& . /opt/ros/$ROS_DISTRO/install/setup.sh \
&& apt-get update \
&& rosdep update \
&& rosdep install -y \
--ignore-src \
--from-paths src \
Expand Down
15 changes: 12 additions & 3 deletions docker_build_ros.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ reset=`tput sgr0`
docker_image_name=rbonghi/isaac-ros-base
BASE_DIST=ubuntu20.04
CUDA_VERSION=11.4.1
OPENCV_VERSION=4.5.0
OPENCV_VERSION=4.6.0
BUILD_BASE=devel

usage()
Expand Down Expand Up @@ -273,7 +273,14 @@ main()
elif [ $option = "humble" ] ; then
# Humble reference
TAG="humble-$ROS_PKG-$BUILD_BASE"
BASE_IMAGE=$docker_image_name:$BUILD_BASE
if [ $ROS_PKG = "core" ] ; then
BASE_IMAGE=$docker_image_name:$BUILD_BASE
elif [ $ROS_PKG = "base" ] ; then
BASE_IMAGE=$docker_image_name:humble-core-$BUILD_BASE
else
echo "${red}Error base image!${reset}"
exit 1
fi
#### HUMBLE #############
message_start $PUSH $CI_BUILD $TAG
echo " - ${bold}HUMBLE ${green}${ROS_PKG^^}${reset} image"
Expand All @@ -283,6 +290,7 @@ main()
$push_value \
$CI_OPTIONS \
-t $docker_image_name:$TAG \
-t $docker_image_name:$TAG-${OPENCV_VERSION}-cuda${CUDA_VERSION}-${BASE_DIST} \
--build-arg BASE_IMAGE="$BASE_IMAGE" \
$multiarch_option \
-f Dockerfile.humble.$ROS_PKG \
Expand All @@ -292,7 +300,7 @@ main()
elif [ $option = "gems" ] ; then
# tag and image reference
TAG="gems-$BUILD_BASE"
BASE_IMAGE=$docker_image_name:humble-core-$BUILD_BASE
BASE_IMAGE=$docker_image_name:humble-base-$BUILD_BASE
#### Message #############
message_start $PUSH $CI_BUILD $TAG
echo " - ${bold}${option^^}${reset} image"
Expand All @@ -302,6 +310,7 @@ main()
$push_value \
$CI_OPTIONS \
-t $docker_image_name:$TAG \
-t $docker_image_name:$TAG-${OPENCV_VERSION}-cuda${CUDA_VERSION}-${BASE_DIST} \
--build-arg BASE_IMAGE="$BASE_IMAGE" \
$multiarch_option \
-f Dockerfile.isaac \
Expand Down

0 comments on commit 0fde084

Please sign in to comment.