Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies libproc, bindgen #24

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Update dependencies libproc, bindgen #24

merged 3 commits into from
Sep 26, 2023

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Sep 24, 2023

Updating these dependencies fixes LiveSplit/asr-debugger#2, a build error that I had similar to #23

@acj acj linked an issue Sep 25, 2023 that may be closed by this pull request
@AlexKnauth
Copy link
Contributor Author

AlexKnauth commented Sep 25, 2023

It looks like the FreeBSD CI builds are failing because they can't get the latest bindgen versions on crates.io. The latest version should be 0.68.1, released 2023-09-06, but the most recent candidate version mentioned on the CI failures is 0.65.1, released 2023-04-10.

I don't know whether there's an actual version constraint somewhere or whether it's just pulling from an old crates.io catalog. If it's just an old crates.io catalog, where would it need to be updated?

Edit: in the .github/workflows/ci.yml file I see references to a dated cargo cargo-20230425, and that matches up with 0.65.1 being the most recent bindgen version at the time of 2023-04-25.

@CryZe
Copy link

CryZe commented Sep 25, 2023

You could try changing the date there (it's only a cache key, so it only matters that it's different it seems). It looks like it was the solution to the same problem before: 8c58272

@AlexKnauth
Copy link
Contributor Author

There was also the test failure on Windows. When I try running that test, it seems to get stuck somewhere in the while address < sysinfo.lpMaximumApplicationAddress loop in get_process_page_ranges in src/win_maps.rs.

When I run it the address stays at 0x10000, leading to an infinite loop. meminfo.BaseAddress is also 0x10000, meminfo.RegionSize is 0x7ffd0000, but then meminfo.BaseAddress.add(meminfo.RegionSize) just produces 0x10000 again like it didn't add anything at all.

@AlexKnauth
Copy link
Contributor Author

Looks like Try changing cache key dates didn't work, it's still not showing any version of bindgen after 0.65.1, released 2023-04-10.

@CryZe
Copy link

CryZe commented Sep 25, 2023

Seems like there is no issue with a locally generated Cargo.lock, so it's indeed a weird quirk of the CI setup here.

@acj
Copy link
Member

acj commented Sep 25, 2023

Thanks for trying the cache workaround. Our FreeBSD vagrant image hasn't been rebuilt in a while, so I'm going to try that and will report back.

@acj
Copy link
Member

acj commented Sep 26, 2023

The new FreeBSD images worked here with your original commit. Can you rebase your branch onto master and try again?

@AlexKnauth
Copy link
Contributor Author

Okay, I've rebased it onto master excluding the Try changing cache key dates commit

Copy link
Member

@acj acj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to make a release later today.

@acj acj merged commit f7434a7 into rbspy:master Sep 26, 2023
7 checks passed
@acj
Copy link
Member

acj commented Sep 27, 2023

This is in 0.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing on my Mac New release with libproc_rs version bump
3 participants