Twig 1.27+ support #294
Merged
Twig 1.27+ support #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2da74cf on SCIF:twig_127 into ** on rcrowe:master**. |
barryvdh
reviewed
Dec 25, 2016
| @@ -105,7 +105,7 @@ public function get($path, array $data = []) | |||
| */ | |||
| protected function handleTwigError(Twig_Error $ex) | |||
| { | |||
| $templateFile = $ex->getTemplateFile(); | |||
| $templateFile = $ex->getSourceContext()->getPath(); | |||
There was a problem hiding this comment.
Is this possible for all exceptions?
|
This PR broke the package, at least for me. Type error: Argument 1 passed to Twig_Loader_Chain::addLoader() must implement interface Twig_LoaderInterface, instance of TwigBridge\Twig\Loader given, called in /../app/vendor/twig/twig/lib/Twig/Loader/Chain.php on line 30twig/twig: v1.30.0 |
|
Rwveeted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some deprecations and limited min version of twig 1.27+. Should fix #291.Replaces #290.