Added command-line parameters to override the default x-width and y-width settings #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-width settings. Some documents don't have the default proportions of 1872x1404 pixels (for example, US Letter documents). Exporting the lines file as SVGs will result in lines placed at incorrect locations when superimposed onto the original PDF in those cases. The problem is solved when overriding these default settings with the proper pixel values for the document size (1805x1404 in the case of US Letter). The proposed modification allows users to specify these values as (optional) command line arguments. The default behavior of the program is left unchanged.
… of more than 99 pages)
|
Also added possibility for more than 99 pages in output filenames |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some documents don't have the default proportions of 1872x1404 pixels (for
example, US Letter documents). Exporting the lines file as SVGs will
result in lines placed at incorrect locations when superimposed onto the
original PDF in those cases. The problem is solved when overriding these
default settings with the proper pixel values for the document size
(1805x1404 in the case of US Letter). The proposed modification allows
users to specify these values as (optional) command line arguments. The
default behavior of the program is left unchanged.