Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Animation to the Logo #109

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

akuya-ekorot
Copy link
Member

@akuya-ekorot akuya-ekorot commented Nov 14, 2022

Fixes Issue #108

Closes #108

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

2022-11-14_03-01-16.mp4

Note to reviewers

  • It's not a video file, nor a gif but an animated svg with data in a json file. This makes it scale without pixelation and saves on space.
  • The total size of the animated logo is 110kbs
  • The packages "react-lottie" and "@types/react-lottie" were installed to implement this.

@vercel
Copy link

vercel bot commented Nov 14, 2022

@akuya-ekorot is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 10:23am

Copy link
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akuya-ekorot Nice touch on the Logo there, this looks really great.

Before merging this in, can you please add some documentation for people who have never worked with Lottie animations before? I want to be sure that we have enough information to maintain this code once merged in.

Please add a section in the README with information like What is Lottie? How is the JSON file generated? How can the animation be changed? and any other useful information that would help in the future maintenance of this code.

While at it, also kindly resolve the merge conflicts.

@orama254
Copy link
Member

Hello @akuya-ekorot, any progress on the requested changes for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Logo Animation
3 participants