-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Animation to the Logo #109
base: develop
Are you sure you want to change the base?
Add Custom Animation to the Logo #109
Conversation
@akuya-ekorot is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel. @reactdeveloperske first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akuya-ekorot Nice touch on the Logo there, this looks really great.
Before merging this in, can you please add some documentation for people who have never worked with Lottie animations before? I want to be sure that we have enough information to maintain this code once merged in.
Please add a section in the README with information like What is Lottie? How is the JSON file generated? How can the animation be changed? and any other useful information that would help in the future maintenance of this code.
While at it, also kindly resolve the merge conflicts.
Hello @akuya-ekorot, any progress on the requested changes for this? |
Fixes Issue #108
Closes #108
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
2022-11-14_03-01-16.mp4
Note to reviewers