Server side rendering issue fix with Remarkable (#356)

reactjs · Jan 5, 2017 · 8529758 · 8529758
1 parent cef84b0
commit 8529758
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/site/jekyll/getting-started/tutorial.md b/site/jekyll/getting-started/tutorial.md
@@ -995,11 +995,16 @@ var CommentBox = React.createClass({
 });
 ```
 
-We also need to update the `Comment` component to use `Remarkable` from either `global` or `window`, due to a bug in Remarkable:
+We also need to update the `Comment` component to use `Remarkable` from either `global` or `window`, due to a bug in Remarkable. We will do this by creating a function to create an instance of `Remarkable` and then calling it from the `Comment` component:
 ```javascript{3}
+function createRemarkable() {
+    var remarkable = (("undefined" != typeof global) && (global.Remarkable)) ? global.Remarkable : window.Remarkable;
+    return new remarkable();
+}
+
 var Comment = React.createClass({
 	rawMarkup: function () {
-		var md = new (global.Remarkable || window.Remarkable)();
+		var md = createRemarkable();
 		var rawMarkup = md.render(this.props.children.toString());
 		return { __html: rawMarkup };
 	},

diff --git a/tutorial-code/wwwroot/js/tutorial.jsx b/tutorial-code/wwwroot/js/tutorial.jsx
@@ -103,9 +103,14 @@ var CommentForm = React.createClass({
 	}
 });
 
+function createRemarkable() {
+    var remarkable = (("undefined" != typeof global) && (global.Remarkable)) ? global.Remarkable : window.Remarkable;
+    return new remarkable();
+}
+
 var Comment = React.createClass({
 	rawMarkup: function () {
-		var md = new (global.Remarkable || window.Remarkable)();
+		var md = createRemarkable();
 		var rawMarkup = md.render(this.props.children.toString());
 		return { __html: rawMarkup };
 	},