Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Describing the UI coherent with translations made in the sub-pages of this section #519

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

abdllahdev
Copy link
Contributor

The current translation of this index page is not coherent with the translations done in the sub-pages in this section. Also the sentences in the code block including images' alt is not translated.

Changes made:

  • Make the translation of this page coherent
  • Translate sentences in the code blocks

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.63 KB (🟢 -12 B) 178.77 KB
/500 75.62 KB (🟢 -12 B) 178.77 KB
/[[...markdownPath]] 77.12 KB (🟢 -12 B) 180.27 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@AhmedBaset AhmedBaset merged commit d8e486f into reactjs:main Aug 13, 2023
2 checks passed
@AhmedBaset
Copy link
Collaborator

I like this kind of PRs thanks

@abdllahdev
Copy link
Contributor Author

Thanks you @A7med3bdulBaset.

I think we need to coordinate our translations better in the future so we can have a coherent translation across all pages. The current issue where people discussed the glossary is a bit messy which can be confusing for some people so I guess we need to pick a couple of dictionaries and say that these are our only references. We can also try to come to an agreement for some of the words that aren't in these dictionaries.

I found the Arabyese dictionary and the Dictionary of Information Technology Terms to be quit useful for technical terms. I think we need to put them somewhere so people can follow them when translating new pages.

@AhmedBaset
Copy link
Collaborator

Great idea.

We already have Wiki and Glossary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants