Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Managing State page #522

Merged
merged 34 commits into from
Aug 22, 2023
Merged

Translate Managing State page #522

merged 34 commits into from
Aug 22, 2023

Conversation

Rumbustious
Copy link
Contributor

@Rumbustious Rumbustious commented Aug 19, 2023

Here are some notes the might help the reviewers:

  • The title "Managing State" is translated to "التحكم في الحالة" based on Describing the UI page translation, "إدارة الحالة" may be a better translation for it but it's not a big deal.
  • Word "Structure" is translated to "هيكل" or "هيكلة", it could also be translated to "هيئة".
  • "Props drilling" is translated to "تسرب الخصائص", it could also be translated to "استنزاف الخصائص".
  • The comment in line 90: // Pretend it's hitting the network. is translated to // محاكاة للتواصل باستخدام الشبكة, if there is a better translation for it let me know!
  • Countries, cities, places, and people names are kept untranslated: "Kazakhstan, Almaty, Lima, Kyoto, Lennon wall, Bob, Alice, Taylor, Philosopher’s Path"
  • "Extracting" is translated to "استخلاص", it could also be translated to "استخراج"
  • "actions" is translated to "إجراءات"
  • "sub-sub heading" is translated to "عنوان فرعي ثان" I think it's better than saying "عنوان فرعي فرعي".
  • "State Logic" is translated to "منطق الحالة" & "State updated logic" is translated to "منطق تحديث الحالة".
  • "Reducer" is translated to "مخفض" this according to hsoub translation, it could be translated to "مختصر".
  • "Context" is translated to "السياق".

    - Overview
    - Reacting to input with state
    - Choosing the state structure
    - sidebarLearn translation
    - Sharing State Between Components
    - Preserving and Resetting State
    - Extracting state logic into a reducer
    - Passing data deeply with context
    - Scaling up with reducer and context
    - Revised mistakes.
    - Changed some words translations.
    - Added translations for code blocks
    - removed an apostrophe
    - typos mistake in sidebarLearn
    - Keep 'Philosopher’s Path' untranslated
@AhmedBaset AhmedBaset self-assigned this Aug 21, 2023
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.31 KB (-1 B) 181.26 KB
/500 77.31 KB (-1 B) 181.26 KB
/[[...markdownPath]] 78.82 KB (-1 B) 182.77 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

src/sidebarLearn.json Outdated Show resolved Hide resolved
Co-authored-by: Ahmed Abdelbaset <A7med3bdulBaset@gmail.com>
    - Fix RTL
    - words left without translations
Rumbustious and others added 2 commits August 22, 2023 11:23
    - Translate words that were left untranslated.
@AhmedBaset
Copy link
Collaborator

I pushed a commit that might throw a warning on your end when you push. run git pull

@Rumbustious
Copy link
Contributor Author

Rumbustious commented Aug 22, 2023

I pushed a commit that might throw a warning on your end when you push. run git pull

Yeah, I've noticed that there's a commit I can't find. I've ran git pull in my local repo.

src/sidebarLearn.json Outdated Show resolved Hide resolved
Co-authored-by: Ahmed Abdelbaset <A7med3bdulBaset@gmail.com>
Co-authored-by: Ahmed Abdelbaset <A7med3bdulBaset@gmail.com>
@AhmedBaset AhmedBaset merged commit af34e29 into reactjs:main Aug 22, 2023
2 checks passed
@AhmedBaset
Copy link
Collaborator

ترجمة ممتازة تم دمج الفرع
قد تكون دي أحسن ترجمة راجعتها هنا
شكرًا لك

@Rumbustious
Copy link
Contributor Author

ترجمة ممتازة تم دمج الفرع قد تكون دي أحسن ترجمة راجعتها هنا شكرًا لك

الشكر لك أخي، ومجهوداتك بالترجمة والتعديل خرافية!
سأقوم بالبدء في العمل على كلٍ من الصفحات:
Reacting to Input with State
Choosing the State Structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants