Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Using TypeScript Page #524

Closed
wants to merge 1 commit into from
Closed

Translate Using TypeScript Page #524

wants to merge 1 commit into from

Conversation

mahmood601
Copy link
Contributor

@mahmood601 mahmood601 commented Aug 27, 2023

Finally 😄
It take from me alt of time, I hope that it will be empty from errors and misunderstanding 😁❤️

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.31 KB (-2 B) 181.26 KB
/500 77.31 KB (-2 B) 181.26 KB
/[[...markdownPath]] 78.82 KB (-2 B) 182.77 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@AhmedBaset AhmedBaset self-requested a review August 27, 2023 20:02
@mahmood601 mahmood601 closed this Aug 29, 2023
@mahmood601 mahmood601 deleted the translating-ts-page branch August 29, 2023 05:44
@AhmedBaset
Copy link
Collaborator

@mahmood601 Why did you close that?

@mahmood601
Copy link
Contributor Author

@mahmood601 Why did you close that?

I don't know!
I'm beginner in using Github and git 😅

@mahmood601
Copy link
Contributor Author

I don't have to close pull request and delete the branch, I have to send the changes on the same branch 🤦🏻‍♂️

@AhmedBaset
Copy link
Collaborator

I saw you've already opened another pull request #526

Read this comment #521 (comment)
It's like a cheat sheet of git

@mahmood601
Copy link
Contributor Author

I saw you've already opened another pull request #526

Read this comment #521 (comment)
It's like a cheat sheet of git

Thanks, I will read that sheet 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants