Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2 #151

Merged
merged 83 commits into from
Sep 20, 2024
Merged

Version 2 #151

merged 83 commits into from
Sep 20, 2024

Conversation

danielweck
Copy link
Member

@danielweck danielweck commented Sep 4, 2024 •
edited by JayPanoz
Loading

[Edit from Jiminy to list changes]

This new major version:

  • removes responsive columns
  • allows developers to apply the number of columns they see fit, w/o any restriction
  • adds a flag to disable vertical-writing pagination for developers who prefer to implement their own
  • removes a hack for older versions of Chromium, that created performance issues in some conditions
  • replaces page margins user setting with line length user setting
  • attempts to improve the handling of overflowing text
  • re-implements the font-size user setting
  • extends the application of the font-family user setting
  • improves the default font-stacks
  • updates recommandations for libre and open source fonts
  • adds support for variable fonts
  • adds a font-patch for Android dealing with rare occurrences of missing fonts in fixed-layout.

JayPanoz added 30 commits June 20, 2024 10:34
@JayPanoz
Remove -webkit-perspective hack (resolves #119)
228bad1
@JayPanoz
Remove webkit-line-box-contain safeguard (resolves #113)
91e59fb
@JayPanoz
Remove responsive columns (resolves #143)
ff49e4c
@JayPanoz
Init migration guide
7b67138
@JayPanoz
Update migration guide
27ef0e1
@JayPanoz
Implement line length user setting
9c63005 
Part of issue #130 resolution
@JayPanoz
Remove page margins setting
c020af2 
Resolves #130
@JayPanoz
Fix responsive columns removal
20dcacc
@JayPanoz
Update migration guide
609caae
@JayPanoz
Clarify pageGutter in migration
96b9199
@JayPanoz
Add test for user line length
3bf5a5a
@JayPanoz
Remove page margins test
f3123ee
@JayPanoz
Update version
14139cc
@JayPanoz
Remove postcss-custom-media from build script
d774cdb
@JayPanoz
Serve demo via express
c646a36 
So that it can be kept in sync more easily, and get around local files restrictions.
@JayPanoz
Correct docs for colCount and modules order
619977c
@JayPanoz
Add variable fonts pref submodules
839cd5e
@JayPanoz
Add regression tests
939b171
@JayPanoz
Update docs for variable fonts settings
502707d
@JayPanoz
Correct comment in fontWeight submodule
9863532
@JayPanoz
Correct font width test
4613739
@JayPanoz
Update docs following test corrections
33d8c0b
@JayPanoz
Add bold in font-weight test
62163e7
@JayPanoz
Change variable font for optical-sizing test
ae27482
@JayPanoz
Modify font-width so that it can accept keywords
ee863a9
@JayPanoz
Add variable font tests in typeface tester util
4313b87
@JayPanoz
Correct variations test and add utils to server
280cfda
@JayPanoz
Add support for google variations in typetester
4a2863a
@JayPanoz
Update libre fonts doc with variations
0f26685
@JayPanoz
Add header for optical sizing
341c470 
Font-size depends on the font for the font-optical-sizing property so it may not be visible when only checking paragraphs
JayPanoz added 18 commits August 26, 2024 10:08
@JayPanoz
Update fragmented model for vertical-writing
6adcd73
@JayPanoz
Align vertical pagination with the default one
2cf269c 
Remove --RS__pageGutter on :root for more consistency
@JayPanoz
Clarify pageGutter in docs
8cf4ecf
@JayPanoz
Add input in demo
b8c04bb 
So that you can add from the API w/o using debug tools
@JayPanoz
Allow colCount pref to accept any integer
a53d43a
@JayPanoz
Extend font-family setting overrides
37bf973 
Resolves #147
@JayPanoz
Create flag to disable vertical-writing pagination
f46f3bd 
As convenience to implementers’ preferring to implement theirs.
@JayPanoz
Update EBPAJ font patch in dist
0fc2806
@JayPanoz
Add script to update dist patches on build
e10cc2a
@JayPanoz
Add Android Fonts Patch
4ec8de5 
Resolves #149
@JayPanoz
Update migration guide with android fonts patch
385b45b
@JayPanoz
Update japanese font changes in docs
4f9b62f
@JayPanoz
Update EPUB doc
8a68193
@JayPanoz
Update migration guide
c705d33 
Following engineering call agreed changes: number of columns, font-family override, flag to disable vertical writing pagination
@JayPanoz
Add clarification re. vertical writing pagination
fc36a45 
Why implementers may want to disable the default and how it’s being done.
@JayPanoz
Update migration guide in EPUB docs
b696a7e
@JayPanoz
Merge branch 'develop' into v2
729c6a7
@JayPanoz
Rebuild dist and EPUB
ec48b4d
mickael-menu
mickael-menu reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job as usual! I left a few comments but saw nothing that would cause real trouble in the mobile toolkits.

docs/CSS28-migration_guide.md Show resolved Hide resolved
docs/CSS28-migration_guide.md Outdated Show resolved Hide resolved
docs/CSS28-migration_guide.md Show resolved Hide resolved
docs/CSS03-injection_and_pagination.md Show resolved Hide resolved
docs/CSS03-injection_and_pagination.md Outdated Show resolved Hide resolved
docs/CSS12-user_prefs.md Show resolved Hide resolved
@JayPanoz JayPanoz mentioned this pull request Sep 11, 2024
Closed
@JayPanoz
Remove font-size normalize from doc details
90231d9
@JayPanoz
Simplify pagination
5680018 
Remove 100vw as a condition for single-col from module and user-setting submodule. Using auto will prioritize column-count and resolve to 100% anyway.
@JayPanoz @github-actions
Update dist
2874d9b
@JayPanoz
Run audit fix
e9e92ee
@JayPanoz
Merge branch 'develop' into v2
8f7d6b5
@JayPanoz JayPanoz marked this pull request as ready for review September 20, 2024 07:31
@JayPanoz JayPanoz changed the title V2 PREVIEW Version 2 Sep 20, 2024
@JayPanoz JayPanoz merged commit f55ca6e into develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickael-menu mickael-menu mickael-menu left review comments

@JayPanoz JayPanoz JayPanoz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielweck @JayPanoz @mickael-menu