Allow closures being directly called to be wrapped into parentheses (#…

…5856)

CHANGELOG.md

@@ -40,6 +40,11 @@
   [SimplyDanny](https://github.com/SimplyDanny)
   [#5787](https://github.com/realm/SwiftLint/issues/5787)
 
+* Stop triggering the `control_statement` rule on closures being directly
+  called as conditions.  
+  [SimplyDanny](https://github.com/SimplyDanny)
+  [#5846](https://github.com/realm/SwiftLint/issues/5846)
+
 * Do not trigger `self_in_property_initialization` rule on `self` in
   key paths expressions.  
   [SimplyDanny](https://github.com/SimplyDanny)

Source/SwiftLintBuiltInRules/Rules/Style/ControlStatementRule.swift

@@ -29,6 +29,8 @@ struct ControlStatementRule: Rule {
             Example("switch (lhs, rhs) {}"),
             Example("if (f() { g() {} }) {}"),
             Example("if (a + f() {} == 1) {}"),
+            Example("if ({ true }()) {}"),
+            Example("if ({if i < 1 { true } else { false }}()) {}", excludeFromDocumentation: true),
         ],
         triggeringExamples: [
             Example("↓if (condition) {}"),
@@ -176,7 +178,7 @@ private extension ExprSyntax {
    private func containsTrailingClosure(_ node: Syntax) -> Bool {
         switch node.as(SyntaxEnum.self) {
         case .functionCallExpr(let node):
-            node.trailingClosure != nil
+            node.trailingClosure != nil || node.calledExpression.is(ClosureExprSyntax.self)
         case .sequenceExpr(let node):
             node.elements.contains { containsTrailingClosure(Syntax($0)) }
         default: false