Link: add cyclic dependency check when change link

realthunder · Feb 15, 2018 · c144941 · c144941
1 parent 2cf0cca
commit c144941
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/App/Link.cpp b/src/App/Link.cpp
@@ -859,6 +859,11 @@ void LinkBaseExtension::setLink(int index, DocumentObject *obj,
     if(!parent)
         LINK_THROW(Base::RuntimeError,"No parent container");
 
+    auto inSet = parent->getInListEx(true);
+    inSet.insert(parent);
+    if(inSet.find(obj)!=inSet.end())
+        LINK_THROW(Base::RuntimeError,"Cyclic dependency");
+
     auto linkProp = getLinkedObjectProperty();
 
     // If we are a group (i.e. no LinkObject property), and the index is