Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fixtures): correctly encode secrets in base64 (#131) #131

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mdonadoni
Copy link
Member

@mdonadoni mdonadoni commented May 3, 2024

mdonadoni added a commit to mdonadoni/pytest-reana that referenced this pull request May 6, 2024
@mdonadoni mdonadoni changed the title refactor(fixtures): update secrets-related fixtures (#131) fix(fixtures): correctly encode secrets in base64 (#131) May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 5.16%. Comparing base (9477298) to head (7dd1b14).
Report is 2 commits behind head on master.

Files Patch % Lines
pytest_reana/fixtures.py 0.00% 4 Missing ⚠️
pytest_reana/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #131      +/-   ##
=========================================
- Coverage    5.18%   5.16%   -0.03%     
=========================================
  Files           5       5              
  Lines         212     213       +1     
=========================================
  Hits           11      11              
- Misses        201     202       +1     
Files Coverage Δ
pytest_reana/version.py 0.00% <0.00%> (ø)
pytest_reana/fixtures.py 3.70% <0.00%> (-0.02%) ⬇️

mdonadoni added a commit to mdonadoni/pytest-reana that referenced this pull request Aug 8, 2024
@mdonadoni mdonadoni marked this pull request as ready for review August 8, 2024 12:06
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release news suggestion (to indicate that the PR properly encodes all secrets now):

fix(fixtures): encode all user secrets in base64 (#131)

@tiborsimko tiborsimko merged commit 7dd1b14 into reanahub:master Aug 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secrets: avoid repeated calls to k8s API
2 participants