Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(k8s): avoid fetching secrets multiple times (#456) #456

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mdonadoni
Copy link
Member

Closes #455

mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request May 6, 2024
mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Aug 8, 2024
@mdonadoni mdonadoni marked this pull request as ready for review August 8, 2024 13:06
mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Aug 19, 2024
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be good to release pytest-reana first, then bump its version here in this PR, so that the CI checks would pass.

A suggestion for the release news: instead of:

perf(k8s): avoid fetching secrets multiple times

we could perhaps say "avoid repetitive fetching of user secrets" or "avoid extraneous fetching..." or "avoid unnecessary refetching..." etc for the message clarity?

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 85.57692% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.10%. Comparing base (273b72d) to head (4816f90).
Report is 2 commits behind head on master.

Files Patch % Lines
reana_commons/k8s/secrets.py 85.41% 14 Missing ⚠️
reana_commons/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   34.84%   37.10%   +2.25%     
==========================================
  Files          26       26              
  Lines        1650     1652       +2     
==========================================
+ Hits          575      613      +38     
+ Misses       1075     1039      -36     
Files Coverage Δ
reana_commons/k8s/kerberos.py 92.00% <100.00%> (+92.00%) ⬆️
reana_commons/version.py 0.00% <0.00%> (ø)
reana_commons/k8s/secrets.py 82.75% <85.41%> (+12.93%) ⬆️

@tiborsimko tiborsimko merged commit 4816f90 into reanahub:master Aug 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secrets: avoid repeated calls to k8s API
2 participants