-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(k8s): avoid fetching secrets multiple times (#456) #456
Conversation
6c02ed7
to
e26308c
Compare
e26308c
to
e9cc2d9
Compare
e9cc2d9
to
6d0f7f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be good to release pytest-reana
first, then bump its version here in this PR, so that the CI checks would pass.
A suggestion for the release news: instead of:
perf(k8s): avoid fetching secrets multiple times
we could perhaps say "avoid repetitive fetching of user secrets" or "avoid extraneous fetching..." or "avoid unnecessary refetching..." etc for the message clarity?
6d0f7f8
to
77d263e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 34.84% 37.10% +2.25%
==========================================
Files 26 26
Lines 1650 1652 +2
==========================================
+ Hits 575 613 +38
+ Misses 1075 1039 -36
|
Closes #455