Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secrets): adapt to reana-commons secret-handling changes (#686) #686

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mdonadoni
Copy link
Member

Refactor secrets-related endpoints to adapt to performance-related
refactor of reana-commons. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455

mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request May 6, 2024
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 8, 2024
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
@mdonadoni mdonadoni marked this pull request as ready for review August 8, 2024 13:08
mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 8, 2024
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 8, 2024
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 19, 2024
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
…anahub#686)

Refactor secrets-related endpoints to adapt to performance-related
refactor of `reana-commons`. Improve validation of endpoints'
parameters.

Closes reanahub/reana-commons#455
@tiborsimko tiborsimko merged commit 3596ee0 into reanahub:master Aug 21, 2024
12 checks passed
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (703af19) to head (3596ee0).
Report is 1 commits behind head on master.

Files Patch % Lines
reana_server/rest/secrets.py 35.71% 18 Missing ⚠️
reana_server/rest/gitlab.py 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   60.98%   60.87%   -0.12%     
==========================================
  Files          33       33              
  Lines        3440     3458      +18     
==========================================
+ Hits         2098     2105       +7     
- Misses       1342     1353      +11     
Files Coverage Δ
reana_server/gitlab_client.py 86.00% <100.00%> (ø)
reana_server/utils.py 59.28% <ø> (-0.13%) ⬇️
reana_server/rest/gitlab.py 42.05% <25.00%> (-0.40%) ⬇️
reana_server/rest/secrets.py 38.23% <35.71%> (+2.23%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secrets: avoid repeated calls to k8s API
2 participants