Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Dragging #294

Merged
merged 30 commits into from
Nov 13, 2024
Merged

Cluster Dragging #294

merged 30 commits into from
Nov 13, 2024

Conversation

amcdnl
Copy link
Member

@amcdnl amcdnl commented Nov 4, 2024

This PR:

  • Implements Cluster Drag/Drop

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit a8d11a0
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/6734596c2cc897000826c64c
😎 Deploy Preview https://deploy-preview-294--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amcdnl
amcdnl commented Nov 5, 2024
View reviewed changes
src/store.ts Show resolved Hide resolved
amcdnl
amcdnl commented Nov 5, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as ready for review November 7, 2024 08:17
@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as draft November 7, 2024 12:59
@SerhiiTsybulskyi SerhiiTsybulskyi marked this pull request as ready for review November 7, 2024 13:24
amcdnl
amcdnl commented Nov 12, 2024
View reviewed changes
Copy link
Member Author

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback.

src/store.ts Show resolved Hide resolved
src/store.ts Show resolved Hide resolved
src/useGraph.ts Outdated Show resolved Hide resolved
src/useGraph.ts Outdated Show resolved Hide resolved
src/useGraph.ts Show resolved Hide resolved
src/symbols/Cluster.tsx Outdated Show resolved Hide resolved
src/symbols/Cluster.tsx Show resolved Hide resolved
docs/demos/Cluster.story.tsx Outdated Show resolved Hide resolved
docs/demos/Cluster.story.tsx Outdated Show resolved Hide resolved
amcdnl
amcdnl commented Nov 12, 2024
View reviewed changes
src/CameraControls/useCameraControls.ts
/**
* A function that freezes the camera.
*/
freeze: () => void;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this name but its fine for now.

amcdnl
amcdnl commented Nov 12, 2024
View reviewed changes
src/useGraph.ts Outdated Show resolved Hide resolved
amcdnl
amcdnl commented Nov 12, 2024
View reviewed changes
src/symbols/Node.tsx Outdated Show resolved Hide resolved
amcdnl
amcdnl commented Nov 12, 2024
View reviewed changes
Copy link
Member Author

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things, mainly around naming and comments.

src/useGraph.ts Show resolved Hide resolved
src/store.ts Show resolved Hide resolved
src/layout/forceInABox.ts Show resolved Hide resolved
src/CameraControls/CameraControls.tsx Outdated Show resolved Hide resolved
docs/demos/Cluster.story.tsx Show resolved Hide resolved
@amcdnl amcdnl merged commit 9f7346b into master Nov 13, 2024
5 checks passed
@amcdnl amcdnl deleted the cluster-dragging-take2 branch November 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiTsybulskyi SerhiiTsybulskyi SerhiiTsybulskyi left review comments

@ghsteff ghsteff Awaiting requested review from ghsteff

@evgenoid evgenoid Awaiting requested review from evgenoid

Assignees

@SerhiiTsybulskyi SerhiiTsybulskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcdnl @SerhiiTsybulskyi