Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop using internal Relude_* in tests #344

Closed
wants to merge 1 commit into from

Conversation

mlms13
Copy link
Member

@mlms13 mlms13 commented Nov 4, 2023

This is a chunk of the work that was happening in @trite's dunification branch. Specifically, this makes it so all of the tests in __tests__ no longer use Relude_* modules, which are internal and won't be available to the tests module once we properly set up dune packages.

@mlms13 mlms13 changed the base branch from main to v2 November 4, 2023 19:38
@mlms13
Copy link
Member Author

mlms13 commented Nov 4, 2023

Ugh... never mind. I forgot that in the pre-dunification branch, everything requires esy to build, and I can't seem to npm install -g esy on my Mac without hitting weird code signing errors. Not sure I have the patience to tackle this independently of the dune work, so I'm just going to close this PR.

@mlms13 mlms13 closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant