-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Initialize originalInput in OperationParams #1142
base: master
Are you sure you want to change the base?
Fix: Initialize originalInput in OperationParams #1142
Conversation
@tallesborges test are failing, can you check? |
Ensure that `originalInput` is initialized to an empty array if the value is null. This prevents potential null reference errors during operations.
@mfn, to be honest, I'm not sure if it's necessary to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change still leaves a discrepancy with \Rebing\GraphQL\Support\OperationParams::getOriginalInput()
, which accesses the parent one and not the shallow copy array of our class.
Can you better explain you use case which triggered all of this?
Removed redundant baseOperationParams property and replaced it with direct internal mappings. This reduces complexity and enhances code readability by accessing variables and read-only flag directly within OperationParams.
It aims to fix the |
any comments @mfn ? |
No, sorry, I still don't understand the intention of the change :/ |
Summary
$originalInput
property in theinit
method ofOperationParams
class.$originalInput
is properly set from theBaseOperationParams
object during initialization.$originalInput
and maintains consistency with other properties initialized in theinit
method.Type of change:
Checklist:
composer fix-style