Skip to content

Commit

Permalink
[SYCL][ESIMD][E2E] Fix compile time properties block store test (inte…
Browse files Browse the repository at this point in the history
…l#11725)

The mask logic was wrong. I manually verified the test on PVC.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
  • Loading branch information
sarnex authored Oct 31, 2023
1 parent e3e88f2 commit 22c9574
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/block_store.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ bool testUSM(queue Q, uint32_t Groups, uint32_t Threads,
simd<uint32_t, N> PassThruInt(ElemOff, 1);
simd<T, N> Vals = PassThruInt;
if constexpr (UseMask) {
simd_mask<1> Mask = (GlobalID + 1) % 1;
simd_mask<1> Mask = (GlobalID + 1) & 0x1;
block_store(Out + ElemOff, Vals, Mask, StorePropertiesT{});
Vals = block_load<T, N>(Out + ElemOff);
Vals += 1;
Expand Down Expand Up @@ -100,7 +100,7 @@ bool testUSM(queue Q, uint32_t Groups, uint32_t Threads,
bool Passed = true;

for (int i = 0; i < Size; i++) {
bool IsMaskSet = (i / N + 1) % 1;
bool IsMaskSet = (i / N + 1) & 0x1;
Tuint Expected = sycl::bit_cast<Tuint>(Out_val);
if (!UseMask || IsMaskSet)
Expected = sycl::bit_cast<Tuint>((T)(i + 6));
Expand Down

0 comments on commit 22c9574

Please sign in to comment.