Skip to content

Commit

Permalink
Revert "Fix Coverity dereference before null check issue (intel#13456)…
Browse files Browse the repository at this point in the history
…" (intel#13818)

This reverts commit c02f915 since this
Coverity issue is a false positive. `EventImpl` is always set when we
pass it in the runtime, but the previous change suggests it might be
null. The Coverity hit should be ignored instead.
  • Loading branch information
julianmi authored May 21, 2024
1 parent 5baec4d commit 5c6616c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sycl/source/detail/graph_impl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ class graph_impl {
void addEventForNode(std::shared_ptr<graph_impl> GraphImpl,
std::shared_ptr<sycl::detail::event_impl> EventImpl,
std::shared_ptr<node_impl> NodeImpl) {
if (EventImpl && !(EventImpl->getCommandGraph()))
if (!(EventImpl->getCommandGraph()))
EventImpl->setCommandGraph(GraphImpl);
MEventsMap[EventImpl] = NodeImpl;
}
Expand Down

0 comments on commit 5c6616c

Please sign in to comment.