Skip to content

Commit

Permalink
[SYCL] Revert recent copy requirements temporarily (intel#9970)
Browse files Browse the repository at this point in the history
This commit reverts the recently introduced requirements on
`is_device_copyable` in copy commands. This is a temporary revert until
`sycl::vec` is made trivially copyable, to appropriately satisfy
`is_device_copyable` implicitly.

---------

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
  • Loading branch information
steffenlarsen committed Jun 19, 2023
1 parent 1a6f7a5 commit 83f8779
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sycl/include/sycl/handler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2289,8 +2289,8 @@ class __SYCL_EXPORT handler {
"Invalid accessor target for the copy method.");
static_assert(isValidModeForDestinationAccessor(AccessMode),
"Invalid accessor mode for the copy method.");
static_assert(is_device_copyable<T_Src>::value,
"Pattern must be device copyable");
// TODO: Add static_assert with is_device_copyable when vec is
// device-copyable.
// Make sure data shared_ptr points to is not released until we finish
// work with it.
CGData.MSharedPtrStorage.push_back(Src);
Expand Down Expand Up @@ -2360,8 +2360,8 @@ class __SYCL_EXPORT handler {
"Invalid accessor target for the copy method.");
static_assert(isValidModeForDestinationAccessor(AccessMode),
"Invalid accessor mode for the copy method.");
static_assert(is_device_copyable<T_Src>::value,
"Pattern must be device copyable");
// TODO: Add static_assert with is_device_copyable when vec is
// device-copyable.
#ifndef __SYCL_DEVICE_ONLY__
if (MIsHost) {
// TODO: Temporary implementation for host. Should be handled by memory
Expand Down

0 comments on commit 83f8779

Please sign in to comment.