Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
fabiomestre committed Jul 30, 2024
1 parent 3c22a5f commit 88ab19c
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -890,8 +890,8 @@ updating command groups as described in the next section.

The command-groups of a kernel node can be updated using dynamic command-groups.
Dynamic command-groups allow replacing the command-group function of a kernel
node with a different one. This effectively allows updating the kernel binaries, the
argument types, the number of arguments and/or the execution ranges.
node with a different one. This effectively allows updating the kernel function
and/or the kernel execution range.

Command-group updates are performed by creating an instance of the
`dynamic_command_group` class. A dynamic command-group is created with a modifiable
Expand All @@ -904,7 +904,7 @@ dynamic parameters can be used in command-group functions that are part of
dynamic command-groups. Updates to such dynamic parameters will be reflected
in the command-group functions once they are activated.

====== Finalizing updates
====== Committing Updates

Updating a node using the methods mentioned above will take effect immediately
for nodes in modifiable command-graphs. However, for graphs that are in the executable
Expand Down Expand Up @@ -1343,9 +1343,9 @@ void update(node& node);
----

| Updates an executable graph node that corresponds to `node`. `node` must be a
kernel execution node. Kernel arguments and the command-group function of the
node will be updated inside the executable graph to reflect the current values
in `node`.
kernel execution node. The command-group function of the node will be updated,
inside the executable graph, to reflect the current values in `node`. This
includes the kernel function, the kernel nd-range and the kernel parameters".

Updating these values will not change the structure of the graph.

Expand Down Expand Up @@ -1377,9 +1377,10 @@ void update(const std::vector<node>& nodes);
----

| Updates all executable graph nodes that corresponds to the nodes contained in
`nodes`. All nodes must be kernel nodes. Kernel arguments and the
command-group function of each node will be updated inside the executable graph
to reflect the current values in each node in `nodes`.
`nodes`. All nodes must be kernel nodes. The command-group function of each node
will be updated, inside the executable graph, to reflect the current values in
`nodes`. This includes the kernel function, the kernel nd-range and the kernel
parameters".

Updating these values will not change the structure of the graph.

Expand Down

0 comments on commit 88ab19c

Please sign in to comment.