-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Fix recording in_order queue with empty nodes #246
[SYCL][Graph] Fix recording in_order queue with empty nodes #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, always a nice patch when removing code fixes an issue.
sycl/test-e2e/Graph/RecordReplay/dotp_in_order_with_empty_nodes.cpp
Outdated
Show resolved
Hide resolved
0508e42
to
1b6dd83
Compare
If I'm not mistaken this change also changes the default behaviour of the handler when Graphs are not involved which I'm not sure about. Now an empty command group is passed to the scheduler instead of doing nothing and just returning an empty event. The potential for unnecessary overhead there concerns me, and in general I think we should avoid modifying the default behaviour unless it is necessary or it improves it in some way. |
a16914d
to
78cbfc8
Compare
Thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nitpicks!
Adding a empty node to a recorded in-order queue resulted in inconsistent dependencies between nodes. This patch fixes this issues and simplifies the adding of empty nodes. Unitests have been added to check node dependencies when recording an in_order queue with and without empty nodes. Fixes Issue: #239
78cbfc8
to
7f683f8
Compare
Adding a empty node to a recorded in-order queue resulted in inconsistent dependencies between nodes.
This patch fixes this issues and simplifies the adding of empty nodes.
Unitests have been added to check node dependencies when recording an in_order queue with and without empty nodes.
Fixes Issue: #239