[SYCL][Graph] Add exceptions for inconsistent contexst or devices on begin_recording #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
added
the
Graph Implementation
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
2da710c
to
1f724e0
Compare
Bensuo
approved these changes
Jul 6, 2023
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_contexts.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_contexts.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_contexts.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_contexts.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Jul 6, 2023
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_contexts.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/RecordReplay/record_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
1f724e0
to
8e9d2a5
Compare
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
8e9d2a5
to
4b9388a
Compare
|
This test should also be updated https://github.com/reble/llvm/blob/sycl-graph-develop/sycl/unittests/Extensions/CommandGraph.cpp#L157 |
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
4b9388a
to
380ee3a
Compare
Verified locally on Windows that your fix works 👍 |
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
380ee3a
to
05e3fb9
Compare
EwanC
approved these changes
Jul 7, 2023
sycl/test-e2e/Graph/RecordReplay/exception_inconsistent_devices.cpp
Outdated
Show resolved
Hide resolved
… device on begin_recording Adds expection throwing if Graph and Queue contexts/devices differ when calling begin_recording. Adds tests to check for thrown exeptions.
mfrancepillois
force-pushed
the
maxime/exeption_contexts_devices_begin_recording
branch
from
05e3fb9
to
9441e73
Compare
mfrancepillois
deleted the
maxime/exeption_contexts_devices_begin_recording
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exception throwing if Graph and Queue contexts/devices differ when calling begin_recording.
Adds tests to check for thrown exceptions.